fix(table): reject row ranges for format tables at read construction - #700
Open
jackylee-ch wants to merge 1 commit into
Open
fix(table): reject row ranges for format tables at read construction#700jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormatTableScan::planrejects row ranges, butFormatReadBuilder::new_readnever readsself.row_ranges, sowith_row_ranges(..).new_read()on a format table returns every rowinstead of the requested ranges. The Python binding has a short-circuit that skips planning
(
bindings/python/src/read.rs:313), so this path is reachable.Fix: fail closed in
new_readtoo, matchingReadBuilder::new_read, which guards thesame way for the same reason.