Skip to content

fix(cli): project turn.stop inputs to protocol fields #4305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsiu93 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix(cli): project turn.stop inputs to protocol fields #4305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/cli/src/__tests__/runtime-host-run-command.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,7 @@ describe('Runtime Host maka run adapter', () => {
const prepareStarted = deferred<void>();
const fixture = runFixture({
graph: true,
strictTurnStopInput: true,
prepareGate: prepareGate.promise,
onPrepareStarted: () => prepareStarted.resolve(),
});
Expand Down Expand Up @@ -868,6 +869,7 @@ function runFixture(input: {
onGraphStop?: () => void;
initialMessages?: StoredMessage[];
finalMessages?: StoredMessage[];
strictTurnStopInput?: boolean;
}) {
const switches: string[] = [];
const moves: string[] = [];
Expand Down Expand Up @@ -1008,6 +1010,13 @@ function runFixture(input: {
return { rootSessionId: requestInput.rootSessionId, graphId: 'graph-1' };
}
if (operation === 'turn.stop') {
if (input.strictTurnStopInput) {
const allowed = new Set(['sessionId', 'turnId', 'runId']);
const unexpected = Object.keys(requestInput).filter((key) => !allowed.has(key));
if (unexpected.length > 0) {
throw new Error(`Unknown turn.stop input field: ${unexpected.join(', ')}`);
}
}
exactTurnStops.push({
sessionId: String(requestInput.sessionId),
turnId: String(requestInput.turnId),
Expand Down
6 changes: 5 additions & 1 deletion packages/cli/src/runtime-host-run-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,11 @@ class RuntimeHostRunRuntime implements MakaRunRuntime {
}

async #stopTurn(turn: { sessionId: string; turnId: string; runId: string }): Promise<void> {
await this.#connection.request('turn.stop', turn);
await this.#connection.request('turn.stop', {
sessionId: turn.sessionId,
turnId: turn.turnId,
runId: turn.runId,
});
}

async #stopGraph(sessionId: string): Promise<void> {
Expand Down