fix(cli): project turn.stop inputs to protocol fields - #4305
Open
jsiu93 wants to merge 1 commit into
Open
Conversation
Send turn.stop with a fresh protocol-shaped identity object. Add a strict fixture for the stop-before-start path. Generated-by: pi (gpt-5.6-sol)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Send
turn.stopwith a fresh object containing onlysessionId,turnId, andrunId. The active Turn's localoutcomeclassifier stays outside the protocol payload, so timeout and SIGINT requests reach the Host and abort the foreground tool.Add strict fixture validation to the existing stop-before-start test. The fixture rejects every extra
turn.stopfield and records the exact accepted payload. Scope is limited to the#stopTurnprojection andstrictTurnStopInputfixture.Fixes #4304
Verification
Before the fix, the strict fixture rejected
outcomeas an unknownturn.stopinput field.A live
maka run --yolo --timeout 10returned1in 10.949 seconds. The marker was absent at return and remained absent after 45 seconds.AI use
Select exactly one:
Tool(s) and scope: pi (gpt-5.6-sol), human-reviewed
Checklist
Does this PR entail a change in behavior?