Skip to content

minor: fix issue that fails datasketches tests if they run in certain order(s) #19924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrankChen021 merged 1 commit into from
Aug 8, 2026
Merged

minor: fix issue that fails datasketches tests if they run in certain order(s) #19924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions ...-core/datasketches/src/test/java/org/apache/druid/segment/DatasketchesProjectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package org.apache.druid.segment;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.collect.ImmutableMap;
import org.apache.datasketches.common.Family;
import org.apache.datasketches.hll.HllSketch;
Expand Down Expand Up @@ -97,6 +98,10 @@ public class DatasketchesProjectionTest extends InitializedNullHandlingTest
private static final Closer CLOSER = Closer.create();
private static final Logger LOG = new Logger(DatasketchesProjectionTest.class);

// Not TestHelper.JSON_MAPPER: Jackson caches the AggregatorFactory subtype resolver when it first builds a
// deserializer, so the sketch modules must be registered before anything else uses this mapper.
private static final ObjectMapper JSON_MAPPER = TestHelper.makeJsonMapper();

private static final List<AggregateProjectionSpec> PROJECTIONS = Collections.singletonList(
AggregateProjectionSpec.builder("a_projection")
.virtualColumns(
Expand Down Expand Up @@ -139,15 +144,15 @@ public class DatasketchesProjectionTest extends InitializedNullHandlingTest
public static Collection<?> constructorFeeder()
{
HllSketchModule.registerSerde();
TestHelper.JSON_MAPPER.registerModules(new HllSketchModule().getJacksonModules());
JSON_MAPPER.registerModules(new HllSketchModule().getJacksonModules());
SketchModule.registerSerde();
TestHelper.JSON_MAPPER.registerModules(new SketchModule().getJacksonModules());
JSON_MAPPER.registerModules(new SketchModule().getJacksonModules());
KllSketchModule.registerSerde();
TestHelper.JSON_MAPPER.registerModules(new KllSketchModule().getJacksonModules());
JSON_MAPPER.registerModules(new KllSketchModule().getJacksonModules());
DoublesSketchModule.registerSerde();
TestHelper.JSON_MAPPER.registerModules(new DoublesSketchModule().getJacksonModules());
JSON_MAPPER.registerModules(new DoublesSketchModule().getJacksonModules());
ArrayOfDoublesSketchModule.registerSerde();
TestHelper.JSON_MAPPER.registerModules(new ArrayOfDoublesSketchModule().getJacksonModules());
JSON_MAPPER.registerModules(new ArrayOfDoublesSketchModule().getJacksonModules());

final List<Object[]> constructors = new ArrayList<>();
final DimensionsSpec.Builder dimensionsBuilder =
Expand Down Expand Up @@ -221,7 +226,7 @@ private static IndexBuilder makeBuilder(DimensionsSpec dimensionsSpec, boolean a
{
File tmp = FileUtils.createTempDir();
CLOSER.register(tmp::delete);
return IndexBuilder.create()
return IndexBuilder.create(JSON_MAPPER)
.tmpDir(tmp)
.schema(
IncrementalIndexSchema.builder()
Expand Down
Loading