Skip to content

minor: fix issue that fails datasketches tests if they run in certain order(s) - #19924

Merged
FrankChen021 merged 1 commit into
apache:masterfrom
capistrant:fix-laten-datasketches-ci-flake
Aug 8, 2026
Merged

minor: fix issue that fails datasketches tests if they run in certain order(s)#19924
FrankChen021 merged 1 commit into
apache:masterfrom
capistrant:fix-laten-datasketches-ci-flake

Conversation

@capistrant

Copy link
Copy Markdown
Contributor

Using the shared object mapper after #19881 creates a strict test ordering requirement before this proposed patch. Running DatasketchesProjectionTest after some test classes results in failure. switching to private local object mapper removes the ordering dependency

@capistrant capistrant changed the title build: fix issue that fails datasketches tests if they run in certain order(s) minor: fix issue that fails datasketches tests if they run in certain order(s) Aug 7, 2026

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.

Reviewed 1 of 1 changed files.


This is an automated review by Codex GPT-5.6-Luna(max)

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked all nine parameterized Datasketches test classes migrated in #19881. DatasketchesProjectionTest is the only one using the shared TestHelper.JSON_MAPPER for module registration together with the default IndexBuilder.create(). I found no other test cases with the same order-dependent AggregatorFactory deserialization hazard.

Although JUnit 5’s @ParameterizedClass could restore class-level parameterization, it is still an experimental API and would not eliminate the shared global mapper state. (JUnit API)

@FrankChen021
FrankChen021 merged commit 48a9eea into apache:master Aug 8, 2026
44 of 46 checks passed
@github-actions github-actions Bot added this to the 39.0.0 milestone Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants