Keep TextStringBuilder.reverse from splitting surrogate pairs#756
Merged
garydgregory merged 1 commit intoJun 27, 2026
Merged
Conversation
Member
|
Thank you @alhudz , merged 🚀 |
garydgregory
added a commit
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of apache/commons-lang#1730 to the Commons Text copy of
TextStringBuilder, as requested by @garydgregory.TextStringBuilder.reverse()swaps the buffer onecharat a time, so every surrogate pair is left in low-high order and a supplementary code point becomes malformed UTF-16.StringBuilder/StringBuffer, which this class is documented to mimic, reverse the same input correctly.Repro:
new TextStringBuilder("a😀b").reverse().toString()(a,U+1F600,b).Before:
b\uDE00\uD83Da, a low surrogate ahead of its high surrogate.After:
b😀a, matchingnew StringBuilder("a😀b").reverse().Fix: after the char swap, walk the buffer once and swap each adjacent low-high surrogate pair back to high-low, gated on whether any surrogate was seen during the swap. BMP text, lone unpaired surrogates and odd-length buffers are untouched.
Added
TextStringBuilderTest#testReverseSurrogatePairs, which fails on the current tree and passes with the fix.mvn; that'smvnon the command line by itself.