Keep StrBuilder.reverse from splitting surrogate pairs#1730
Merged
Conversation
Member
|
Hello @alhudz , the CI is running... please port to Apache Commons Text as this class is deprecated here. TY! |
garydgregory
added a commit
that referenced
this pull request
Jun 25, 2026
7 tasks
Contributor
Author
|
Done — ported to Commons Text in apache/commons-text#756, same surrogate-pair restore on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:new StrBuilder("a" + "😀" + "b").reverse()returnsb\uDE00\uD83Da(a low surrogate ahead of its high surrogate), wherenew StringBuilder(...).reverse()returnsb😀a.Cause:reverse()swaps the buffer onecharat a time, so every surrogate pair is left in low-high order and the supplementary code point becomes malformed UTF-16.Fix:after the char swap, walk the buffer once and swap each adjacent low-high surrogate pair back to high-low, matchingStringBuilder/StringBufferwhich this class is documented to mimic. BMP text, lone surrogates and odd-length buffers are untouched.