Repository navigation
refactor(branding): follow the module layout (moves only) - #846
Merged
Merged
Conversation
constants, settings, services, the branding service, presets and the
tenant-overridable definitions and resolution move to branding/core/;
image validation and the reaper to branding/assets/; deps, the shared-
props provider and endpoints to branding/web/; the form components from
components/ to ui/components/. Tests mirror the areas.
branding.{constants,settings,services,tenant_branding,images} and
branding.endpoints.assets stay as deprecated aliases until 0.0.46.
Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
187dcf9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f46cd610.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-layout-branding.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves-only restructure of
modules/brandingtodocs/module-layout.md, same pattern as #845 (api_tokens).constants/settings/services/service/presets/tenant_definitions/tenant_branding->branding/core/images(upload validation) andreaper->branding/assets/(added toDOMAIN_AREAS)deps/shared_props/endpoints->branding/web/components/->ui/components/, page and tests-js imports rewrittentest_branding_*basenamesbranding.{constants,settings,services,tenant_branding,images}andbranding.endpoints.assetsstay as deprecatedsys.modulesaliases (remove_in0.0.46) becausesmpy_modulesimports them;branding/endpoints/is an alias-only package.No logic changes: settings keys, permissions, i18n keys, routes and
app.state.branding.*are unchanged.Verification
make lint,make doctor,make ci-api-types-fresh,make ci-docs-build,make ci-css-buildpassmake test-py(7876 passed, 45 skipped),make test-jspass-W error::DeprecationWarning)/api/branding/logoserves 200image/pnganonymously, 0 console errorshttps://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq