Repository navigation
feat(layout): core/web/ui module layout for new modules (PR 0) - #827
Merged
Merged
Conversation
… Tailwind and Vite Scaffolded modules now keep only looked-up files at the package root (module.py, models, tasks.py, contracts/, pages/, locales/, CSS) and put the rest in core/, web/ and ui/ areas, with tests mirroring the areas. Wheel-installed modules get <pkg>/ui scanned for Tailwind classes and resolved by the host Vite reader. docs/module-layout.md describes the layout and the moves-only migration; host/tests/test_module_layout.py freezes the current roots of existing modules so they only shrink. Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
…able probe claim Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
3977edc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://50a1e782.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-module-layout-frame.simple-module-python.pages.dev |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make new-module/smpy create-modulenow scaffoldcore/,web/andui/areas. The package root keeps only files that are looked up there (module.py,models.py,tasks.py,contracts/,pages/,locales/,theme.css/styles.css).tests/<area>/<feature>/, with module-prefixed basenames and no__init__.py.<pkg>/uiscanned for Tailwind@sourceand resolved by the host Vite reader (module-assets.ts, plus its template copy).components/stays supported.docs/module-layout.md(in the VitePress sidebar).CLAUDE.md,module-authoring, the guides and the shipped skills are updated.host/tests/test_module_layout.pyis a ratchet that freezes the existing modules' roots. No existing module moves in this PR.Verification
make lint: passmake ci-docs-build: passPYTEST_WORKERS=8 make test-py: 7847 passed, 46 skipped. The one failure,test_clean_target_is_not_in_repo, comes from an empty/tmp/.gitplaceholder that reappears in this sandbox. Afterrmdir /tmp/.gitthat file passes (8 passed).make test-js: passTest plan
make new-module name=probescaffolds the area layout and its tests passhttps://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq