Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/tui/src/routes/session/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ import { DialogSessionRename } from "../../component/dialog-session-rename"
import { DialogMessage } from "./dialog-message"
import { DialogFork } from "./dialog-fork"
import { DialogTimeline } from "./dialog-timeline"
import { findUndoBoundary } from "./undo"
import { Sidebar } from "./sidebar"
import { Composer } from "./composer"
import { filetype } from "../../util/filetype"
Expand Down Expand Up @@ -591,10 +592,10 @@ export function Session() {
group: "Session",
slash: { name: "undo" },
run: () => {
const boundary = session()?.revert?.messageID
const message = messages().findLast(
(message): message is SessionMessageUser =>
message.type === "user" && !!message.text.trim() && (!boundary || message.id < boundary),
const message = findUndoBoundary(
messages(),
data.session.input.list(route.sessionID),
session()?.revert?.messageID,
)
if (!message) {
toast.show({ message: "Nothing to undo", variant: "error", duration: 3000 })
Expand Down
11 changes: 11 additions & 0 deletions packages/tui/src/routes/session/undo.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import type { SessionMessageInfo, SessionMessageUser } from "@opencode-ai/client"

export function findUndoBoundary(messages: SessionMessageInfo[], pendingInputIDs: string[], boundary?: string) {
return messages.findLast(
(message): message is SessionMessageUser =>
message.type === "user" &&
!!message.text.trim() &&
!pendingInputIDs.includes(message.id) &&
(!boundary || message.id < boundary),
)
}
38 changes: 38 additions & 0 deletions packages/tui/test/cli/tui/undo.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import { expect, test } from "bun:test"
import type { SessionMessageInfo, SessionMessageUser } from "@opencode-ai/client"
import { findUndoBoundary } from "../../../src/routes/session/undo"

test("selects the latest promoted user message without pending inputs", () => {
expect(findUndoBoundary([user("msg_001", "First"), user("msg_002", "Second")], [])?.id).toBe("msg_002")
})

test("skips the latest user message while it is pending", () => {
expect(findUndoBoundary([user("msg_001", "First"), user("msg_002", "Second")], ["msg_002"])?.id).toBe("msg_001")
})

test("returns no boundary when all user messages are pending", () => {
expect(
findUndoBoundary([user("msg_001", "First"), user("msg_002", "Second")], ["msg_001", "msg_002"]),
).toBeUndefined()
})

test("selects only messages before an existing revert boundary", () => {
expect(
findUndoBoundary([user("msg_001", "First"), user("msg_002", "Second"), user("msg_003", "Third")], [], "msg_003")
?.id,
).toBe("msg_002")
})

test("skips blank user messages", () => {
expect(findUndoBoundary([user("msg_001", "First"), user("msg_002", " \n ")], [])?.id).toBe("msg_001")
})

test("selects a newer promoted message when an earlier message is pending", () => {
expect(
findUndoBoundary([user("msg_001", "First"), user("msg_002", "Pending"), user("msg_003", "Third")], ["msg_002"])?.id,
).toBe("msg_003")
})

function user(id: string, text: string): SessionMessageUser {
return { type: "user", id, text, time: { created: 0 } } satisfies SessionMessageInfo
}
Loading