fix(tui): skip pending undo boundaries - #40130
Open
leizd wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
leizd
marked this pull request as ready for review
August 2, 2026 06:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #39736
Type of change
What does this PR do?
The V2 TUI displays user inputs as soon as they are admitted, before they are promoted into materialized session history.
During that window,
/undocould select the visible pending input as its revert boundary and pass its ID tosession.revert.stage. The server could not resolve that ID yet and returnedMessage not found.This change excludes admitted-but-unpromoted input IDs when selecting the undo boundary. If the latest visible input is still pending,
/undofalls back to the most recent promoted user message. If no promoted user message is available, the existingNothing to undobehavior is preserved.The fix is limited to the TUI and does not add any server events or API surface.
How did you verify your code works?
From
packages/tui:bun test test/cli/tui/undo.test.ts— 6 passed, 0 failedbun typecheck— passedbun test test/cli/tui/session-rows.test.ts— 15 passed, 0 failedgit diff --check— passedThe regression tests cover:
Screenshots / recordings
Not applicable. This changes undo boundary selection and does not introduce a visual UI change.
Checklist