Repository navigation
test(pty): exercise native ConPTY runtime - #12
Merged
Merged
Conversation
jlongster
marked this pull request as ready for review
September 3, 2026 16:18
jlongster
force-pushed
the
conpty-runtime
branch
from
September 3, 2026 17:48
3a1d57d to
64427e2
Compare
jlongster
force-pushed
the
conpty-runtime
branch
from
October 8, 2026 18:10
64427e2 to
cf9aed7
Compare
jlongster
force-pushed
the
windows-pipes
branch
from
October 8, 2026 18:10
3ebd4a5 to
4080241
Compare
Poll the child's console size after resize, because ConPTY applies resizes asynchronously. Describe the startup cursor query as reaching the reader and parser, which is what the test proves on Windows. Also let the fixture entry return when run directly, name the test that tripped the watchdog, allow a ConPTY repaint after the earlier snapshot, and update the CI summary now that named pipes are merged.
Collaborator
Author
|
Review follow-up (5ea6e9b): the Windows resize test now polls the child's console size, since ConPTY applies resizes asynchronously; the startup cursor-query comment/README now claim only that the query reaches the reader and parser; the fixture entry returns cleanly under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1 — native ConPTY runtime
Adds a reusable self-spawned Rust console fixture and six direct TerminalService tests on Unix and Windows, without daemon/client transport. Covers actual child stdin/stdout, Unicode, cwd/env/argv, supported child-PATH lookup, console resize, snapshots/replay, terminal replies, and independent terminals.
Verified at 3a1d57d
Windows run 33777172486:
Core run 33777172540:
P1 basic native runtime gate is complete. P2 termination/EOF/cleanup follows as a separate stacked PR. Named-pipe transport is an independent lane. Do not merge.