Repository navigation
feat(daemon): enable private Windows named-pipe service - #16
Merged
Merged
Conversation
jlongster
force-pushed
the
windows-daemon
branch
from
September 3, 2026 17:51
2a554ee to
040087b
Compare
jlongster
marked this pull request as ready for review
September 3, 2026 18:01
jlongster
force-pushed
the
windows-daemon
branch
from
October 8, 2026 18:10
040087b to
7d6b6b9
Compare
jlongster
force-pushed
the
conpty-cleanup
branch
from
October 8, 2026 18:10
c92abf2 to
09b21db
Compare
Collaborator
Author
|
Restacked onto current
|
jlongster
force-pushed
the
windows-daemon
branch
from
October 8, 2026 18:48
7d6b6b9 to
e7bf332
Compare
Rebased onto named runtime directories and ticket takeover: - Windows uses the shared `--name`/`--runtime-dir` layout instead of a fixed LOCALAPPDATA path, keeping private ACL, reparse, lock and atomic FileRenameInfoEx publication checks (folded from the follow-up rename fixes). - The stale-sibling sweep is shared by Unix and Windows; platforms supply only process liveness and stale endpoint removal. - The shared server uses generation-based ownership, and the Windows handoff test covers takeover while the previous owner is connected.
jlongster
force-pushed
the
conpty-cleanup
branch
from
October 8, 2026 19:05
b81ed97 to
3f2a883
Compare
jlongster
force-pushed
the
windows-daemon
branch
from
October 8, 2026 19:05
e7bf332 to
52a0974
Compare
A crashed daemon leaves its registration behind, and its pipe name is then free for another local user to create. PipeConnection::connect_to checks GetNamedPipeServerProcessId against the registered PID before a client sends its token or input, and the docs require integrations to do the same. Also treat a failed liveness wait as live in the stale-runtime sweep, read the registration through the owner/ACL-checked reader in daemon tests, document that connections must be discarded after a timeout, and describe Windows storage and its NTFS/POSIX-rename requirement in README and SPEC.
Collaborator
Author
|
Review follow-up (4453740):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency correction
The original standalone T3 ancestry exposed an ARM64 owner-loss cleanup watchdog failure under blocked subscriber output. This PR was rebased onto the full P2 runtime cleanup series, not a partial fix. The strict failing daemon regression is unchanged and now passes on both native architectures. Runtime, service, and shared-fixture bytes are identical to the frozen P2 base.
Verification — head 040087b
Unmerged stack
master -> windows-transport(#13)-> windows-pipes(#14)-> conpty-runtime(#12)-> conpty-cleanup(#15)-> windows-daemon(this PR).Base:
conpty-cleanupatc92abf2e6587dac215a2f73e0c0861c162507884.No merges or publication. Source is frozen pending coordinator-led verification. Basic coverage does not claim exhaustive lifecycle coverage, repair the documented Linux blocked-master-write limitation, or add Windows interactive CLI parity.