Repository navigation
fix(@angular/cli): include builder options for build and test in json-help - #34644
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for mapping human-readable builder names to Architect builder identifiers in ArchitectCommandModule (implemented in build and test commands). This allows --json-help to resolve and output schema options grouped under each builder rather than flattening them. Key feedback points out a bug where builders are registered on the root Yargs instance instead of the subcommand-specific instance, which leads to lookup failures, and suggests resolving builder options in parallel using Promise.all. Additionally, the reviewer recommends widening the enum type in JsonHelpOption to support strings, numbers, and booleans for better type safety.
alan-agius4
added
action: review
…-help Allow ArchitectCommandModule subclasses to declare multiple builders so that --json-help resolves and outputs each builder's schema options separately under the builders field. Configure BuildCommandModule with the Application (@angular/build:application) and Library (@angular/build:library) builders, and TestCommandModule with the Unit-test (@angular/build:unit-test) and Karma (@angular/build:karma) builders.
807beca to
9df6408
Compare
alan-agius4
added
action: merge
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Allow
ArchitectCommandModulesubclasses to declare multiple builders so that--json-helpresolves and outputs each builder's schema options separately under thebuildersfield.BuildCommandModulewith theApplication(@angular/build:application) andLibrary(@angular/build:library) builders.TestCommandModulewith theUnit-test(@angular/build:unit-test) andKarma(@angular/build:karma) builders.See: angular/angular#71791
Previews: