Repository navigation
refactor: use TEST_TMPDIR in CLI tests, node: imports, and remove unused devDependencies - #34643
Merged
dgp1130 merged 3 commits intoNov 3, 2026
Conversation
Use process.env['TEST_TMPDIR'] with an assertion in unit tests to ensure hermetic execution within the Bazel sandbox.
Update remaining bare Node.js built-in module imports across packages to use the node: protocol.
angular-robot
Bot
added
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes Node.js built-in module imports by adding the "node:" prefix across multiple files, and refactors several test suites to use process.env['TEST_TMPDIR'] instead of tmpdir() from node:os for managing temporary directories. Additionally, it cleans up redundant devDependencies in the package.json files of several packages. There are no review comments provided, so I have no feedback to address.
Remove unused devDependencies from @angular-devkit/build-angular, @ngtools/webpack, and @angular/ssr package.json files.
alan-agius4
force-pushed
the
refactor/agents-md-and-devdeps-cleanup
branch
from
November 3, 2026 08:54
7f7c867 to
1dbb22c
Compare
alan-agius4
added
action: review
dgp1130
approved these changes
Nov 3, 2026
alan-agius4
added
action: merge
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce repository guidelines across packages:
process.env['TEST_TMPDIR']instead ofos.tmpdir()in CLI unit tests.node:protocol prefix to remaining bare Node.js built-in imports.devDependenciesfrom@angular-devkit/build-angular,@ngtools/webpack, and@angular/ssr.