Skip to content

refactor: use ArrayBufferLike.byteLength for schematic dry run event content #34642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgp1130 merged 2 commits into from
Nov 3, 2026
Merged

refactor: use ArrayBufferLike.byteLength for schematic dry run event content #34642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d480124
refactor(@angular/cli): use ArrayBufferLike.byteLength for dry run ev…
alan-agius4 Nov 3, 2026
d0d5fbb
refactor(@angular-devkit/schematics-cli): use ArrayBufferLike.byteLen…
alan-agius4 Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions packages/angular/cli/src/command-builder/utilities/schematic-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,11 @@ export function subscribeToWorkflow(
);
break;
case 'update':
logs.push(
// TODO: `as unknown` was necessary during TS 5.9 update. Figure out a long-term solution.
`${colors.cyan('UPDATE')} ${eventPath} (${(event.content as unknown as Buffer).length} bytes)`,
);
logs.push(`${colors.cyan('UPDATE')} ${eventPath} (${event.content.byteLength} bytes)`);
files.add(eventPath);
break;
case 'create':
logs.push(
// TODO: `as unknown` was necessary during TS 5.9 update. Figure out a long-term solution.
`${colors.green('CREATE')} ${eventPath} (${(event.content as unknown as Buffer).length} bytes)`,
);
logs.push(`${colors.green('CREATE')} ${eventPath} (${event.content.byteLength} bytes)`);
files.add(eventPath);
break;
case 'delete':
Expand Down
6 changes: 2 additions & 4 deletions packages/angular_devkit/schematics_cli/bin/schematics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,14 +335,12 @@ export async function main({
break;
case 'update':
loggingQueue.push(
// TODO: `as unknown` was necessary during TS 5.9 update. Figure out a long-term solution.
`${styleText(['cyan'], 'UPDATE')} ${eventPath} (${(event.content as unknown as Buffer).length} bytes)`,
`${styleText(['cyan'], 'UPDATE')} ${eventPath} (${event.content.byteLength} bytes)`,
);
break;
case 'create':
loggingQueue.push(
// TODO: `as unknown` was necessary during TS 5.9 update. Figure out a long-term solution.
`${styleText(['green'], 'CREATE')} ${eventPath} (${(event.content as unknown as Buffer).length} bytes)`,
`${styleText(['green'], 'CREATE')} ${eventPath} (${event.content.byteLength} bytes)`,
);
break;
case 'delete':
Expand Down
Loading