Repository navigation
refactor: use ArrayBufferLike.byteLength for schematic dry run event content - #34642
Merged
dgp1130 merged 2 commits intoNov 3, 2026
Merged
Conversation
…ent content Use event.content.byteLength instead of casting ArrayBufferLike to Buffer to access length.
…gth for dry run event content Use event.content.byteLength instead of casting ArrayBufferLike to Buffer to access length.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the logging of file size during schematic updates and creations by replacing the cast to Buffer and .length access with direct usage of the byteLength property on event.content. This change also removes the temporary TypeScript 5.9 workarounds and associated TODO comments. There are no review comments to address, and the changes look clean and appropriate.
alan-agius4
added
the
target: patch
alan-agius4
added
action: review
dgp1130
approved these changes
Nov 3, 2026
alan-agius4
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve TypeScript 5.9 TODO comments by using
event.content.byteLengthdirectly onArrayBufferLikeinstead of casting throughunknowntoBuffer.