Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"test:watch": "bun test --watch"
},
"dependencies": {
"@altertable/data-app-manifest": "0.72.0",
"@altertable/data-app-manifest": "0.73.0",
"@clack/prompts": "1.7.0",
"oauth4webapi": "3.8.7",
"yaml": "2.9.0"
Expand Down
2 changes: 1 addition & 1 deletion cli/scripts/smoke-data-app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export async function smokeDataApp(
'@altertable/data-app-react',
'@altertable/data-app-bun',
]) {
if (manifest.dependencies?.[name] !== '0.72.0')
if (manifest.dependencies?.[name] !== '0.73.0')
throw new Error(
`Packaged starter must pin ${name} to the tested release`
);
Expand Down
6 changes: 3 additions & 3 deletions cli/src/commands/app/lib/distribution.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ test('distribution embeds a deterministic starter with an exact package pin and
JSON.parse(files['package.json']!).dependencies['@altertable/data-app']
).toBe(recommendedDataAppVersion());
expect(JSON.parse(files['package.json']!).dependencies).toMatchObject({
'@altertable/data-app': '0.72.0',
'@altertable/data-app-react': '0.72.0',
'@altertable/data-app-bun': '0.72.0',
'@altertable/data-app': '0.73.0',
'@altertable/data-app-react': '0.73.0',
'@altertable/data-app-bun': '0.73.0',
});
expect(files['src/main.tsx']).toContain("from '@altertable/data-app-react'");
expect(files['src/preview.ts']).toContain(
Expand Down
17 changes: 0 additions & 17 deletions cli/src/commands/app/lib/file-dev-server.ts.txt

This file was deleted.

6 changes: 2 additions & 4 deletions cli/src/commands/app/lib/file-dev.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,11 @@ throw new Error("must not execute");`
);
const starter = JSON.parse(dataAppPayload.starter['package.json']!);
expect(manifest.dependencies).toEqual(starter.dependencies);
expect(manifest.scripts).toEqual({ dev: 'bun server.ts' });
expect(manifest.scripts).toEqual({ dev: 'data-app-preview' });
expect(await readFile(join(directory, 'bun.lock'), 'utf8')).toBe(
dataAppPayload.starter['bun.lock']!
);
expect(await readFile(join(directory, 'server.ts'), 'utf8')).toContain(
'@altertable/data-app-bun/preview'
);
expect(existsSync(join(directory, 'server.ts'))).toBe(false);
expect(
await prepare(app('{ organization: "acme", environment: "production" }'))
).toBe(directory);
Expand Down
4 changes: 1 addition & 3 deletions cli/src/commands/app/lib/file-dev.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { mkdir, writeFile } from 'node:fs/promises';
import { join } from 'node:path';

import serverScript from '@/commands/app/lib/file-dev-server.ts.txt';
import { recommendedDataAppVersion } from '@/commands/app/lib/package.ts';
import { dataAppPayload } from '@/commands/app/lib/payload.ts';
import { readRequiredFile } from '@/commands/app/lib/remote.ts';
Expand Down Expand Up @@ -37,13 +36,12 @@ export async function prepareFilePreview(
);
const starter = dataAppPayload.starter;
const packageJson = JSON.parse(starter['package.json']!);
packageJson.scripts = { dev: 'bun server.ts' };
packageJson.scripts = { dev: 'data-app-preview' };
await mkdir(directory, { recursive: true });
const files = {
'package.json': `${JSON.stringify(packageJson, null, 2)}\n`,
'bun.lock': starter['bun.lock']!,
'bunfig.toml': starter['bunfig.toml']!,
'server.ts': serverScript,
};
await Promise.all(
Object.entries(files).map(([name, content]) =>
Expand Down
28 changes: 14 additions & 14 deletions data-app/starter/bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions data-app/starter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
"build": "bun build src/index.html --outdir=dist --production"
},
"dependencies": {
"@altertable/data-app": "0.72.0",
"@altertable/data-app-bun": "0.72.0",
"@altertable/data-app-react": "0.72.0",
"@altertable/data-app": "0.73.0",
"@altertable/data-app-bun": "0.73.0",
"@altertable/data-app-react": "0.73.0",
"react": "19.3.0",
"react-dom": "19.3.0"
},
Expand Down
4 changes: 2 additions & 2 deletions data-app/tests/bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion data-app/tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"typescript": "7.0.2"
},
"dependencies": {
"@altertable/data-app": "0.72.0"
"@altertable/data-app": "0.73.0"
}
}
Loading