Skip to content

refactor(app): use the data-app 0.73.0 preview launcher - #165

Merged
francoischalifour merged 3 commits into
mainfrom
fc/use-data-app-file-dev
Oct 20, 2026
Merged

francoischalifour merged 3 commits into
mainfrom
fc/use-data-app-file-dev

Conversation

@francoischalifour

Copy link
Copy Markdown
Member

What

Use data-app 0.73.0’s published data-app-preview launcher for altertable app dev --file, replacing the generated server script. Align package pins and lockfiles to 0.73.0.

Why

The package now owns preview startup, dependency resolution, and shutdown. The CLI retains profile scope validation and the credential proxy.

Verification

  • Full ./scripts/verify.sh passed, including 42 browser tests and the packaged CLI smoke test.
  • Packaged file preview bundled the app, queried through the credential proxy, and stopped cleanly on SIGTERM.
  • The subsequent README paragraph removal passed git diff --check.

Checklist

  • Tests updated
  • Changelog entry already covers single-file preview; this change replaces its implementation
  • No breaking change

Adopt data-app 0.73.0 and run data-app-preview from the cached preview project. Remove the generated server script so the package owns dependency resolution, startup, and signal cleanup, while the CLI retains scope validation and the credential proxy.
@francoischalifour
francoischalifour enabled auto-merge (squash) October 20, 2026 16:01
@francoischalifour
francoischalifour merged commit 5ea6f1c into main Oct 20, 2026
15 checks passed
@francoischalifour
francoischalifour deleted the fc/use-data-app-file-dev branch October 20, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants