Skip to content

feat: update active hosted deployment compute - #527

Merged
alongubkin merged 4 commits into
mainfrom
alon/alien-611-active-hosted-compute
Aug 30, 2026
Merged

feat: update active hosted deployment compute#527
alongubkin merged 4 commits into
mainfrom
alon/alien-611-active-hosted-compute

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • route active hosted push deployment compute changes through Platform
  • avoid taking the private manager lock from generated deployment CLIs
  • make repeated requests idempotent

Test

  • cargo test -p alien-deploy-cli hosted_compute_update_uses_deployment_token_and_exact_payload --lib
  • cargo check -p alien-deploy-cli
  • cargo fmt -p alien-deploy-cli -- --check

ALIEN-611

@greptile-apps

greptile-apps Bot commented Aug 30, 2026

Copy link
Copy Markdown

Greptile Summary

The PR routes compute changes for running hosted push deployments through a deployment-scoped Platform request while avoiding the normal manager acquisition flow.

  • Adds explicit-setting detection so omitted non-compute defaults do not block compute-only updates.
  • Rejects requests that combine compute changes with explicit network, updates, or telemetry changes.
  • Adds an authenticated PATCH helper and focused request-payload tests.
  • Adds httpmock as a development dependency for the deploy CLI.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
crates/alien-deploy-cli/src/commands/up.rs Adds the hosted compute-update fast path, explicit non-compute change checks, authenticated Platform request helper, and focused tests; both previously reported settings-handling defects are addressed.
crates/alien-deploy-cli/Cargo.toml Adds httpmock as a test-only dependency.
Cargo.lock Records the deploy CLI's new development dependency without changing runtime behavior.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[alien-deploy up] --> B{Running hosted push deployment<br/>with compute settings?}
    B -->|No| C[Normal deployment workflow]
    B -->|Yes| D{Explicit non-compute<br/>setting changed?}
    D -->|Yes| E[Reject combined request]
    D -->|No| F{Compute differs from<br/>persisted settings?}
    F -->|No| G[Report already configured]
    F -->|Yes| H[PATCH Platform compute endpoint<br/>with deployment token]
    H --> I[Report update accepted]
Loading

Reviews (3): Last reviewed commit: "fix(deploy-cli): compare only explicit h..." | Re-trigger Greptile

Comment thread crates/alien-deploy-cli/src/commands/up.rs
Comment thread crates/alien-deploy-cli/src/commands/up.rs Outdated
@alongubkin
alongubkin merged commit d8831ab into main Aug 30, 2026
24 checks passed
@alongubkin
alongubkin deleted the alon/alien-611-active-hosted-compute branch August 30, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant