Skip to content

feat: update active hosted deployment compute - #526

Closed
alongubkin wants to merge 1 commit into
mainfrom
feat/configure-active-cloud-deployments
Closed

feat: update active hosted deployment compute#526
alongubkin wants to merge 1 commit into
mainfrom
feat/configure-active-cloud-deployments

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • route active hosted push deployment compute changes through Platform
  • avoid taking the private manager lock from generated deployment CLIs
  • make repeated requests idempotent

Test

  • cargo test -p alien-deploy-cli hosted_compute_update_uses_deployment_token_and_exact_payload --lib
  • cargo check -p alien-deploy-cli
  • cargo fmt -p alien-deploy-cli -- --check

@alongubkin

Copy link
Copy Markdown
Member Author

Superseded by #527 on the repository-compliant ALIEN-611 branch.

@alongubkin alongubkin closed this Aug 30, 2026
@greptile-apps

greptile-apps Bot commented Aug 30, 2026

Copy link
Copy Markdown

Greptile Summary

The PR routes compute changes for active hosted push deployments through the Platform API and adds a focused HTTP contract test.

  • Detects active hosted push deployments and compares requested compute against stored stack settings.
  • Sends changed compute settings to the Platform using the deployment token.
  • Adds httpmock as a deploy-CLI development dependency.
  • The new early-return path currently skips other settings supplied alongside compute.

Confidence Score: 4/5

The early return must be fixed before merging because an update that includes compute can report success while silently dropping other requested deployment changes.

The new hosted-compute branch handles only the compute comparison or PATCH and then exits before the existing public-endpoint validation and remaining deployment update flow.

Files Needing Attention: crates/alien-deploy-cli/src/commands/up.rs

Important Files Changed

Filename Overview
crates/alien-deploy-cli/src/commands/up.rs Adds the hosted compute PATCH and its test, but the enclosing early returns discard other requested changes.
crates/alien-deploy-cli/Cargo.toml Adds the workspace-managed httpmock development dependency used by the new unit test.
Cargo.lock Adds the existing workspace httpmock package as a dependency of alien-deploy-cli.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[alien-deploy up] --> B[Initialize and fetch deployment]
  B --> C{Running hosted push deployment with compute?}
  C -->|No| D[Existing validation and deployment flow]
  C -->|Yes| E{Compute changed?}
  E -->|Yes| F[PATCH Platform compute endpoint]
  E -->|No| G[Report compute already configured]
  F --> H[Return]
  G --> H
  H -. bypasses .-> I[Public endpoint validation and other updates]
Loading

Fix all with Greploop Fix All in Codex

Prompt To Fix All With AI
### Issue 1
crates/alien-deploy-cli/src/commands/up.rs:1344-1350
**Early return drops requested settings**

When a running hosted push deployment is updated with compute plus other settings, both compute branches return before the remaining update flow, causing the command to report success without validating or applying settings such as public endpoints.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "feat(deploy-cli): update active hosted c..." | Re-trigger Greptile

Comment on lines +1344 to +1350
return Ok(());
}
output::success(&format!(
"Deployment '{}' already has the requested compute settings.",
name
));
return Ok(());

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Early return drops requested settings

When a running hosted push deployment is updated with compute plus other settings, both compute branches return before the remaining update flow, causing the command to report success without validating or applying settings such as public endpoints.

Knowledge Base Used: CLI and deployment workflows

Prompt To Fix With AI
This is a comment left during a code review.
Path: crates/alien-deploy-cli/src/commands/up.rs
Line: 1344-1350

Comment:
**Early return drops requested settings**

When a running hosted push deployment is updated with compute plus other settings, both compute branches return before the remaining update flow, causing the command to report success without validating or applying settings such as public endpoints.

**Knowledge Base Used:** [CLI and deployment workflows](https://app.greptile.com/alien/-/custom-context/knowledge-base/alienplatform/alien/-/docs/cli-and-deployment.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant