TestApp in the round-trip harness; carry external-entity and OData-service content on create or modify (#743)

[ako]

Part of #743 (tracking #714). Scope items 1 and 3 are done, and item 2 is done for the OData service and the external entity. The workflow and OData client rewrites are not carried yet; their refusal now gives the right advice. The remainder is listed at the end.

What changed

1. ako/TestApp as a round-trip fixture (test(roundtrip) commit)

• testdata/testapp is a git submodule pinned at 11a8fca. TestTestAppRoundTrip runs it with its own allowlist in mdl/roundtrip/testapp_allowlist_test.go; like PedApp's, that list may only shrink. When the submodule is not initialised, the test skips and says how to initialise it.
• The harness now takes a fixture (dir, .mpr, allowlist). PedApp's test and allowlist are unchanged.
• New unitKeywords mappings: Rest$ConsumedODataService → odata client, ODataPublish$PublishedODataService2 → odata service. External entities are also enumerated as external entity. Workflows were already mapped.
• New TestTestAppCreateOrModifyProbe. For each kind whose describe still prints a plain create (workflow, odata client, external entity), it runs the describe output with the verb rewritten to create or modify, under the same laws and with its own allowlist. A kind switches its verb only when none of its documents is on that list. This test is the evidence behind item 3.
• CI: submodules: true on the build-and-test checkout, and nothing else, because CI: integration step is near its 30-minute budget #757/CI: split integration tests into parallel suites; shard the upgrade property test (#757) #758 are changing the same workflow.

2. Carry

• Domain model / external entity (fix(domain model)):
  • LocalizeDate is now read and written. Before, every DateTime in a rewritten domain model lost it, including DateTimes of sibling entities.
  • An absent LocalizeDate is read as true, Mendix's default and what mxcli has always written. Producers that don't know the value (contract import, MCP reader, API builder, System module) set true.
  • Rest$ODataKey Parts use list marker 2.
  • Both create or modify external entity forms now carry each attribute's OData mapping, its mapped default and LocalizeDate, matched by name. The from odata client form also keeps attribute $IDs.
  • describe external entity prints String(36) instead of String.
• OData service (fix(odata service)):
  • The modify path carries entity-set PageSize when the statement does not page, the stored entity-set order, and each member's CanBeEmpty.
  • ExportLevel is read, and written only when stored.
  • AuthenticationTypes uses marker 1, which is what Studio Pro wrote on all 3 TestApp services. The old marker 3 matched the legacy writer, not Studio Pro.
• Refusal advice (fix(refusal)): a plain create of an existing workflow or OData client now points to alter workflow / alter odata client and says why create or modify is not yet safe. The external-entity and OData-service messages still suggest create or modify, because those rewrites now carry.

3. Verb switch. describe odata service now emits create or modify. All 3 TestApp services passed the probe, and they now pass both laws in the main round trip. Workflow, OData client and external entity keep the plain create.

Design choices the ADRs did not settle

• Absent LocalizeDate reads as true. mxcli has always written DateTimes without the key. Reading absent as false would have made the fix unlocalize every mxcli-authored DateTime on the next write of its domain model. Date is unchanged: it still writes no key. Making Date write false would change what it means, so under ADR-0011 it belongs behind mdl 1. Not done here.
• The probe rewrites the verb instead of changing describe. Losses can be measured before the switch, and the switch is a separate, visible allowlist change.
• ExportLevel and CanBeEmpty are carried only when stored. A service mxcli creates gets the same BSON as before.
• External entity keeps the plain create, although its carry is done. Its probe now fails only on the NoGeneralization Has*Attr=false flags. That is Round-trip harness: untracked describe → exec losses on the Studio Pro fixture (microflows, entities, pages, snippets, menus, roles, JS actions) #721 B, shared by every entity, and it is fixed there, not here.

Test plan (all run locally)

• make build, make lint (Go and TypeScript): pass.

• go test ./mdl/executor/ ./mdl/backend/... ./model/... ./api/...: pass.

• go test -tags integration ./mdl/roundtrip/ (PedApp, TestApp, probe, upgrade property test): pass, 808 s.

• go test -tags integration ./mdl/backend/modelsdk/ ./modelsdk/... ./api/...: pass. Also passing: the integration tests in documentation_preserved_test.go and odata_role_grants_test.go.

• Skip path: with testdata/testapp/TestApp moved away, both TestApp tests SKIP and the package passes.

• Revert checks. For each of the following, I removed or stubbed the fix and watched its test fail:

  • LocalizeDate write, read, and absent → true.
  • ODataKey marker.
  • Mapped default read.
  • ExportLevel write.
  • CanBeEmpty write and read.
  • carryStoredAttributeState in the merge, and the mapped-default carry.
  • External-entity from odata client carry.
  • describe external entity type.
  • carryPublishedEntityState.
  • The refusal messages failed their tests before the change.

  At harness level:

  • Reverting the OData service verb makes all 3 TestApp services break exec.
  • Removing the service carry makes all 3 break getput.

  The AuthenticationTypes marker test failed with marker = 3 before the fix.

• Studio Pro check: I ran mx check (mxbuild 11.14.0, TestApp's version) on a copy of TestApp. Then I executed the describe output of the 3 OData services, Clients.Orders, Odata.Devices and Clients.Customer, and ran mx check again. Both runs: 0 errors. I did not use the Studio Pro MCP tunnel.

• CI time: the TestApp round trip adds about 6.5 min, and the probe about 12 s. CI: integration step is near its 30-minute budget #757/CI: split integration tests into parallel suites; shard the upgrade property test (#757) #758 own the CI time budget.

Remaining for #743 (not in this PR)

• Workflow: carry EventSubProcesses, outcome Flows, activity names and sizes on create or modify workflow, or refuse it. Then switch the verb.
• OData client: carry UseQuerySegment, ApplicationId, EndpointId, CatalogUrl, Icon, the proxy settings, Error/HeaderList/ConfigurationEntity microflows, CustomLocationTemplate, and the MetadataReferences/HttpHeaderEntries/ValidatedEntities markers, or refuse. Then switch the verb.
• External entity: switch the verb once Round-trip harness: untracked describe → exec losses on the Studio Pro fixture (microflows, entities, pages, snippets, menus, roles, JS actions) #721 B (NoGeneralization Has*Attr flags) lands.
• An explicit create or modify workflow or create or modify odata client written by a user still rewrites lossily. Only the plain-create advice changed.

🤖 Generated with Claude Code