create or modify carries workflow, OData client and external entity content; describe switches the verb (#743, #764)

[ako]

Closes #743 (the remaining part; TestApp in the harness and the external entity / OData service carries landed in #759). Closes #764.

What changes

Running a Studio Pro document's own describe output now leaves ako/TestApp unchanged for the three kinds that still printed a plain create. describe now emits create or modify for all three.

Workflow (workflow.Workflow1, Workflow1_2)

• Every outcome now stores a Flow. It is empty when the outcome leads nowhere; Workflows$Outcome.flow is Required. Condition outcomes now store a PersistentId, as every other outcome does.
• Activities store RelativeMiddlePoint/Size as "0;0", which is what Studio Pro stores (14 of 14 in TestApp). The writer used to store "".
• An empty EventSubProcesses [2] is written on 11.8+ only (encodeWorkflow). For an older project, Encoder.OmitKeys suppresses only the empty default. Declared sub-processes are never suppressed. MandatoryListMarkers now honours OmitKeys, as MandatoryLists already did.
• The executor carries the stored names of the activities describe cannot name: start1, end1, the ends of branches and sub-processes, jumps and end-of-path markers (workflow_carry_names.go). The pairing is structural. It runs before the CE0495 deduplication, so the carried names take part in it.

Consumed OData service (Clients.OrderODataClient, Odata.Bug1073)

• UpdateConsumedODataService lays the encoded document over the stored one (carryStoredConsumedODataService). This keeps UseQuerySegment, Icon, ExportLevel, CustomLocationTemplate and the list markers. The catalog, proxy and microflow keys that Studio Pro stores as "" stay "".

External entity (Clients.Orders, Odata.Devices)

• The last loss was Round-trip harness: untracked describe → exec losses on the Studio Pro fixture (microflows, entities, pages, snippets, menus, roles, JS actions) #721 B: the four NoGeneralization Has*Attr flags were dropped when false. The writer now writes all four. This also struck 27 TestApp entity and association entries, and it fixes the flags half of PedApp's Round-trip harness: untracked describe → exec losses on the Studio Pro fixture (microflows, entities, pages, snippets, menus, roles, JS actions) #721 B entity entries (their why text is updated; member pointers still fail).
• External entity create or modify keeps the stored RemoteType when the declared attribute type changes #764: a declared type that the service does not publish is refused under mdl 1, with nothing written. Under mdl 0 the statement still writes and warns MDL-V1-REMOTETYPE (langver.Change). Measured with mx check on a TestApp copy: OrderId: String(20) on an Edm.Int64 property gives CE6616. That error is checked against the service's $metadata, not against the stored RemoteType, so deriving a RemoteType from the declared type would not fix it. Refusing was the only option.

Refusal messages. A plain create of an existing workflow or OData client recommends create or modify again, and still names alter for a one-part change.

Design choices the ADRs did not settle

• The OData client carry is a stored-document overlay, not new model fields. A key the writer omits and the model manages is written as "" rather than carried, so a value that alter clears stays cleared.
• The flags fix is a Round-trip harness: untracked describe → exec losses on the Studio Pro fixture (microflows, entities, pages, snippets, menus, roles, JS actions) #721 B fix. It is included because it was the only thing stopping the external-entity round trip. Legacy-writer parity (true flags only) was not Studio Pro parity.
• TestTestAppCreateOrModifyProbe stays for future kinds. With no kind deferred, it skips and requires its allowlist to be empty.

Test plan

• Failing tests written first:
  • TestWorkflowToGen_EveryOutcomeStoresAFlow, ..._ActivityLayoutIsTheStudioProDefault, TestWorkflowEncoder_EmptyEventSubProcessesFromMendix118
  • TestCreateOrModifyWorkflow_CarriesNamesDescribeCannotPrint, with the control ..._ImplicitNamesWithoutStoredNames
  • TestConsumedODataServiceRewrite_CarriesWhatTheModelDoesNotHold / _ModelValuesWin
  • TestEntityToGen_WritesEveryGeneralizationFlag
  • TestCreateOrModifyExternalEntity_RemoteTypeMismatch{RefusedUnderMdl1,WarnsUnderMdl0}, with the control _MatchingTypeCarriesRemoteType
• Revert checks. Reverting each of these made its test fail:
  • the outcome Flow, layout and ESP changes;
  • the name-carry call;
  • the overlay (replaced with the fresh document);
  • the checkRemoteTypes call;
  • the flags change (the test failed before implementation).
• Before switching the verbs, TestTestAppCreateOrModifyProbe was run with its allowlist emptied. Workflows and clients passed after their fixes, and external entities passed after the flags fix.
• go test ./mdl/backend/modelsdk/ ./mdl/executor/ ./modelsdk/codec/ ./mdl/roundtrip/ passes.
• go test -tags integration ./mdl/roundtrip/ passes, run suite by suite with -p 1 because the shared machine OOM-killed the full package: TestApp round trip, PedApp round trip, probe/describe/terminator/flow-modify/misc, and TestUpgrade. 6 #743 entries and 27 #721 entries were struck from the TestApp allowlist. No entries were added.
• mx check (11.14.0) on a TestApp copy passed with 0 errors:
  • after running all six documents' describe output as create or modify (4 were reported unchanged);
  • after creating new workflows with a decision, a parallel split and empty outcomes;
  • the CE6616 measurement above.
• make build, make lint, make check-findings all pass.
• Skills updated: write-workflows, odata-data-sharing. Findings appended.

🤖 Generated with Claude Code