Skip to content

chore: guardrails from the #19 retro - #48

Merged
adrianbrowning merged 2 commits into
mainfrom
retro-19-guardrails
Oct 6, 2026
Merged

adrianbrowning merged 2 commits into
mainfrom
retro-19-guardrails

Conversation

@adrianbrowning

Copy link
Copy Markdown
Owner

Follow-up to #47. Its bump-file fix (5fbda25) was pushed after #47 merged, so it's included here.

Summary

 packages/mdcode/.eslintrc.json
+  no-console, no-restricted-properties (process.stdin/stdout/stderr/exit/exitCode),
+  no-restricted-imports (those names from node:process)
+  override: src/cli.ts, src/main.ts, src/**/*.test.ts
 packages/{mdcode,usage}/package.json   test: --test-reporter=spec -> dot   (test:watch keeps spec)
 .abide/rubric.json                     recompiled from the current CLAUDE.md
 .bumpy/library-cli-boundary.md         transformWithFunction -> update migration: file= is read
 docs/agents/issue-tracker.md           + after closing an issue, re-check the issues it blocked
 TESTING.md                             - mock.method(console) note (no such tests exist)

Evidence

  • Lint guard. src/ lints clean. Linting a sample file named src/commands/list.ts that contained import { stdout } from "node:process", console.log and process.stderr.write failed with no-restricted-imports, no-console and no-restricted-properties. On main before feat!: drop console-printing transform API, add update onBlock (#19) #47, commands/transform.ts would have failed this rule.
  • Abide. The old rubric's source hash (555a20d…) didn't match CLAUDE.md (afb77c5…). Its use-define-transform rule pointed at CLAUDE.md line 92, which no longer exists, and abide report showed it firing 48 times in 49 checks. The new rubric has 13 rules: 5 lint, 6 deferred, 2 unenforceable. abide rubric validate passes and abide calibrate reports no model-checked rules.
  • Test output. pnpm test prints 65 lines, down from about 370. pnpm check passes in the pre-push hook.

Merge Danger

Door: two-way

Blast Radius: tooling

Only lint, test output and docs change; there's no runtime change.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

bumpy-frog

The changes in this PR will be included in the next version bump.

minor Minor releases

  • mdcode-ts 0.0.4 → 0.1.0

Bump files in this PR

Click here if you want to add another bump file to this PR


This comment is maintained by bumpy.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

⚠️ ESLint Check Warnings

Click to see details

Style


> mdcode@0.0.1 lint:s /home/runner/work/mdcode-ts/mdcode-ts
> pnpm -r lint:s

Scope: 2 of 3 workspace projects
packages/mdcode lint:s$ eslint --config .eslintrc.style.json "src/**/*.{j,t}s{,x}" --cache --max-warnings=0
packages/mdcode lint:s: [baseline-browser-mapping] The data in this module is over two months old.  To ensure accurate Baseline data, please update: 'npm i baseline-browser-mapping@latest -D'
packages/mdcode lint:s: Done
packages/usage lint:s$ eslint --config .eslintrc.style.json "{tests,fixtures,examples}/**/*.{j,t}s{,x}" --cache --max-warnings=0
packages/usage lint:s: [baseline-browser-mapping] The data in this module is over two months old.  To ensure accurate Baseline data, please update: 'npm i baseline-browser-mapping@latest -D'
packages/usage lint:s: Done

Correctness


> mdcode@0.0.1 lint:esl /home/runner/work/mdcode-ts/mdcode-ts
> pnpm -r lint:esl

Scope: 2 of 3 workspace projects
packages/mdcode lint:esl$ eslint "src/**/*.{j,t}s{,x}" --cache --max-warnings=0
packages/mdcode lint:esl: [baseline-browser-mapping] The data in this module is over two months old.  To ensure accurate Baseline data, please update: 'npm i baseline-browser-mapping@latest -D'
packages/mdcode lint:esl: Done
packages/usage lint:esl$ eslint "{tests,fixtures,examples}/**/*.{j,t}s{,x}" --cache --max-warnings=0
packages/usage lint:esl: [baseline-browser-mapping] The data in this module is over two months old.  To ensure accurate Baseline data, please update: 'npm i baseline-browser-mapping@latest -D'
packages/usage lint:esl: Done

View workflow run

@adrianbrowning
adrianbrowning merged commit af8ae9d into main Oct 6, 2026
4 checks passed
@adrianbrowning
adrianbrowning deleted the retro-19-guardrails branch October 6, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant