Skip to content

fix: SDK page in dark mode #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-hulbert merged 2 commits into from
Jul 29, 2026
+3 −10
Merged

fix: SDK page in dark mode #3502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b18506
fix(sdks): correct SDK card styling in dark mode
m-hulbert Jul 29, 2026
c6f81df
fix(sdks): remove duplicate React Native card in Pub/Sub
m-hulbert Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/SDKsPage/Card/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export type CardProps = {

const Card = ({ githubRepoURL, setupLink, title, image, text }: CardProps) => {
return (
<section className="p-6 bg-extra-light-grey rounded-lg flex-1">
<section className="p-6 bg-extra-light-grey dark:bg-neutral-1200 rounded-lg flex-1">
<div className="flex items-center justify-between">
<h3 className="ui-text-h3">{title}</h3>
<img key={image.src} src={image.src} height="40px" width={`${image.isWide ? '68px' : '40px'}`} />
Expand Down
2 changes: 1 addition & 1 deletion src/components/SDKsPage/MainSection/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const MainSection = ({ tab }: { tab: Tab }) => {
<hr />
</div>
<div className={`${container}`}>
<p className="ui-text-p1 text-charcoal-grey py-[4.5rem]">{data.tabs[activeTab].text}</p>
<p className="ui-text-p1 py-[4.5rem]">{data.tabs[activeTab].text}</p>
</div>
<CardGrid currentProduct={data.tabs[activeTab].cards} />
</div>
Expand Down
9 changes: 1 addition & 8 deletions src/components/SDKsPage/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import js from './images/js.svg';
import java from './images/java.svg';
import python from './images/python.svg';
import react from './images/react.svg';
import reactnative from './images/reactnative.svg';
import csharp from './images/csharp.svg';
import go from './images/go.svg';
import nodejs from './images/nodejs.svg';
Expand Down Expand Up @@ -57,7 +56,7 @@ export const data = {
{
title: 'React Native',
text: 'Ably React Native SDK.',
image: { src: reactnative, isWide: false },
image: { src: react, isWide: false },
setupLink: 'getting-started/react-native',
},
{
Expand Down Expand Up @@ -144,12 +143,6 @@ export const data = {
image: { src: nativescript, isWide: false },
setupLink: 'https://github.com/ably/ably-js-nativescript#how-to-use-this-library',
},
{
title: 'React Native',
text: 'Ably SDK for React Native.',
image: { src: react, isWide: false },
setupLink: 'getting-started/react-native',
},
{
title: 'Cordova',
text: 'Ably SDK for Cordova.',
Expand Down
Loading