Skip to content

fix: SDK page in dark mode - #3502

Merged
m-hulbert merged 2 commits into
mainfrom
sdk-page-dark-mode
Jul 29, 2026
Merged

fix: SDK page in dark mode#3502
m-hulbert merged 2 commits into
mainfrom
sdk-page-dark-mode

Conversation

@m-hulbert

Copy link
Copy Markdown
Contributor

Description

The SDK page didn't get properly ported to dark mode in #3466. This PR addresses that. It also fixes a duplicate React Native card on Pub/Sub that was using an incorrect logo asset.

Checklist

m-hulbert and others added 2 commits July 29, 2026 13:22
Give SDK cards a dark surface (dark:bg-neutral-1200) so the auto-flipped
light-on-dark card text is legible, and drop the redundant
text-charcoal-grey on the intro paragraph so the ui-text-p1 dark override
governs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Pub/Sub SDK list contained two React Native entries. Remove the
duplicate and use the badged react.svg logo so React Native matches the
React card and the tiled logo style of the other SDKs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@m-hulbert m-hulbert self-assigned this Jul 29, 2026
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d24427f-cc6c-4dde-8f01-cddc29662cef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@m-hulbert m-hulbert added the review-app Create a Heroku review app label Jul 29, 2026
@ably-ci
ably-ci temporarily deployed to ably-docs-sdk-page-dark-ner2t0 July 29, 2026 12:27 Inactive

@AndyTWF AndyTWF left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My retinas thank you 👀

@m-hulbert
m-hulbert merged commit ffc2c9b into main Jul 29, 2026
9 checks passed
@m-hulbert
m-hulbert deleted the sdk-page-dark-mode branch July 29, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

3 participants