cdo: Fix incompatible-pointer-types in cdoseq_load_cdo_from_buffer#47
Open
bradfa wants to merge 1 commit into
Open
cdo: Fix incompatible-pointer-types in cdoseq_load_cdo_from_buffer#47bradfa wants to merge 1 commit into
bradfa wants to merge 1 commit into
Conversation
GCC 14 promotes -Wincompatible-pointer-types to a hard error, so the
build fails with:
utils/src/cdo-load.c:140:14: error: assignment to 'char *' from incompatible pointer type 'uint32_t *' {aka 'unsigned int *'} [-Wincompatible-pointer-types]
140 | data = raw->data;
| ^
make: *** [Makefile:81: build/obj/cdo-load.o] Error 1
The function parameter data is char *, but raw->data (struct CdoRawInfo)
is uint32_t *. The sibling function cdoseq_load_cdo avoids this because
its local data is void *, which accepts any pointer without a cast.
Add an explicit (char *) cast.
Signed-off-by: Andrew Bradford <andrew.bradford@konsulko.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 14 promotes -Wincompatible-pointer-types to a hard error, so the build fails with:
The function parameter data is char *, but raw->data (struct CdoRawInfo) is uint32_t *. The sibling function cdoseq_load_cdo avoids this because its local data is void *, which accepts any pointer without a cast.
Add an explicit (char *) cast.