zynqmp: Fix -verify header signature checking on non-FSBL ACs#48
Open
bradfa wants to merge 1 commit into
Open
Conversation
Each authentication certificate carries a boot header signature that must be signed by that AC's own SPK. Previously only the bootloader (FSBL) partition's AC was checked, so a bad boot header signature on the header-table AC or any non-FSBL partition AC would pass -verify undetected but fail to authenticate on real hardware. Extract the check into VerifyBootHeaderSignature() and call it for the header-table AC and for every authenticated partition (first block only for multi-block partitions), each verified against its own AC's SPK. Follow the seek/read sequence to use the nested style seen in neighbor functions and the partition loop. Fixup the trailing cleanup comment to "// Cleanup handled by unique_ptr", which is the standard phrasing used throughout. Signed-off-by: Andrew Bradford <andrew.bradford@konsulko.com>
bradfa
force-pushed
the
master-verify-check-every-bh
branch
from
b01395c to
0966bba
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each authentication certificate carries a boot header signature that must be signed by that AC's own SPK. Previously only the bootloader (FSBL) partition's AC was checked, so a bad boot header signature on the header-table AC or any non-FSBL partition AC would pass
-verifyundetected but fail to authenticate on real hardware.Extract the check into VerifyBootHeaderSignature() and call it for the header-table AC and for every authenticated partition (first block only for multi-block partitions), each verified against its own AC's SPK.
Follow the seek/read sequence to use the nested style seen in neighbor functions and the partition loop. Fixup the trailing cleanup comment to "// Cleanup handled by unique_ptr", which is the standard phrasing used throughout.