Skip to content

Forward /favicon.png to v2 #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RhysSullivan merged 1 commit into from
Nov 12, 2026
Merged

Forward /favicon.png to v2 #2542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/cloud/src/edge/marketing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ export const isV2Path = (pathname: string): boolean =>
* `/apps/*` and `/experiments/*` are v2's; v2 publishes nothing at a bare
* `/experiments`, which stays with v1. `/demo` is a valid, unreserved v1
* organization slug, so it and everything below it stay with v1. The
* favicons stay with v1 too: v1's dashboard serves identical files. */
* favicons stay with v1 too: v1's dashboard serves identical files. v1 has
* no `/favicon.png`, which v2's OAuth client metadata document names as its
* logo, so that one is v2's. */
const V2_MARKETING_PATHS: ReadonlyArray<string> = [
"/home",
"/pricing",
Expand All @@ -126,6 +128,7 @@ const V2_MARKETING_PATHS: ReadonlyArray<string> = [
"/authors/*",
"/og-image.png",
"/pattern-graph-paper.svg",
"/favicon.png",
];

/** Whether a pathname belongs to v2's marketing site on `executor.sh`. `/`
Expand Down
Loading