Repository navigation
Forward /favicon.png to v2 - #2542
Merged
Merged
Conversation
v2's OAuth client metadata document on executor.sh names https://executor.sh/favicon.png as its logo. v1 has no file at that path, so its SPA fallback answered with HTML. Fixes #2541
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 33344d6 | Nov 11 2026, 11:48 PM |
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 33344d6 | Commit Preview URL Branch Preview URL |
Nov 11 2026, 11:47 PM |
RhysSullivan
marked this pull request as ready for review
November 12, 2026 00:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2541. The patch is from the issue, authored by @AugusDogus.
v2's OAuth client metadata document on executor.sh names
https://executor.sh/favicon.pngas its logo. v1 has no file at that path, so its SPA fallback answers with HTML. This forwards/favicon.pngto v2, the same way as the document itself.The v2 half (UsefulSoftwareCo/executor-next#3823) adds the path to v2's edge contract. The logo stays broken until both deploy.