Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the source GSC gene signatures over the actual native identity owners: isShiny(dvs,context), vanillaShiny, definition-first vanillaGender/gender and randomDVs. Preserve actual gene/definition context identity, vanilla hook bypass, truthiness, invalid-result fallback, callback retirement and the native four-draw source gene order.
This is stacked on PR401/current original main8d5b4387. The independent broader older-host run exposed a real missing prerequisite: existing native roll helpers were not advertised, unified identity callback records were absent, and GBA native producers were not fully wired. Compose the scoped actual identity payload from the existing offered PR169 (including split/aliased trainer identity reads), retaining current source fields/stat/PP/native owners. No absent production facade is invented.
Port the actual broader identity fixtures with every outcome assertion retained. Only setup for the absent newer edition-filter service is adapted to the actual older generation-targeted loader. Initial failing source e700db5 and its receipt are retained; corrected source6cea7865 independently passes all9groups:262168data,450source SDK/native,4976broad identity,142ownership/rollback,5290appearance,63transactions,238refresh,6642PP and185360stat-data checks. See docs/native-gen2-source-identity.md.
Newer-fork receipts do not qualify the older host. Full-suite, GPU and packaged release acceptance remain open, as do the remaining constructor/Mon and standalone battle/turn APIs. No mod, protected Gen1 or player installation is edited.
Contributions by Roxas2712 — https://github.com/Roxas2712
Original integration/tests are offered under https://github.com/Roxas2712/Gen2Recomped/blob/main/LICENSE-ROXAS2712.md, including its specific Cedric / UNDERdecoded permission with visible credit. Existing authors’ rights, provenance, notices and earlier grants remain; included Gen1-derived ScreenPosition retains its GPLv3/Section7 terms.