Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crystal source Mon caught-data edits were not connected to native SRAM export or consumers. This shares the real metadata owner with native catches/PC storage, contest catches before gate transfer, GivePoke, NPC/fixed-OT gifts, hatching, friendship and trade OT marks. All native party/box/daycare codec paths import and export the live fields. Gold/Silver reserved words and unreviewed hack layouts remain opaque.
Depends on offered #402 and its stated prerequisites. The older host additionally lacked native landmark identities and pokemonRecord export; their actual implementations are included and independently tested, without changing test outcome assertions or adding a simulated facade.
Qualification on actual combined implementation 6ce0e17: 393,307 caught-data/API checks (all 65,536 byte pairs), 7,970 native codec checks, 133 native SDK/arrival/consumer/RTC checks, plus fields170, friendship24,270, identity262,168 and actual identity SDK450 checks. All seven selected groups passed. Final commit differs only by the qualification document. Full official suites/GPU/final release acceptance are not claimed for this older upstream candidate.
No supplied mod, ROM, Gen1 install or player profile edits. This is a scoped missing engine API/ownership contribution; it does not complete source Mon/Battle or full VASC parity. Details: docs/NATIVE-GEN2-CAUGHT-DATA-UPSTREAM.md.
Contributions by Roxas2712 — https://github.com/Roxas2712. Independently owned additions are offered to Cedric/UNDERdecoded under LICENSE-ROXAS2712.md, including its visible credit terms. Existing authorship and upstream/Gen1/third-party grants remain effective; no whole foreign file is claimed.
Final setter-preservation follow-up: source setters retain the opaque historical word, and expanded native codec tests invoke both setters directly on all reserved layouts. All seven groups passed again on 6ce0e17; final head dd31d24 differs only by documentation.