Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
…upstream-native-ball-intro-phase
…upstream-native-ball-intro-phase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presentation adapter reported a visible full-size Pokemon before its native throw/opening. Observe the actual native ball visibility, scale and rise for its battler, composing existing move effects. Also observe native trainer/send-out hiding flags before a ball exists. Explicit source overrides retain precedence; the native controller, queue and draw-override path are unchanged.
Validation: 23,160 assertions across five GBA editions and player/opponent/capture balls pass. The exact predecessor reproduces 4,075 failures using the same fixture. Current fork main
72c2a946composition2ad0e77282passes 197 CPU groups; older-public composition0b63737b6apasses 73 groups while retaining its native bodies. Real Metal Ruby611cb4757bwith unchanged consumerbddb5181: zero premature visible player rows in 553 pre-throw observations; all 82 native ball-hidden observations hide the actual actor. Both send-outs, 11 captured throw frames, the command menu and cleanup pass without loader errors. There are no duplicate cells in 378 opening passes. Opening-particle fitting, other portraits/views and full scene/FPS acceptance remain separate. Hosted CI is separate.Owned QA copies/profiles only, 20 GiB free-space floor. Private consumer files, original ROMs and player saves/profiles are unchanged.
Builds on the offered public component stack, including #379. The narrow projection production/test addition is
9917a016..0cf4b40a. Existing cartridge/art/stage/clock prerequisites remain required for raw older main; no newer native controller is overlaid.Contributions by Roxas2712 — https://github.com/Roxas2712. Original additions are offered under LICENSE-ROXAS2712.md, including specific integration/distribution permission for Cedric / UNDERdecoded with visible credit. Existing upstream/third-party licences and rights remain intact.