Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
…upstream-native-ball-intro-phase
…upstream-native-ball-intro-phase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fitted send-out ball cell used its scene projection while the borrowed native opening ring still painted at cartridge screen coordinates. Reuse the current presentation callback for the standalone send-out opening pass, mapping the existing native effects to the same origin and scale. Native painting and capture providers keep their existing coordinate owners; no second ball or particle timeline is added.
Validation: 460 projection assertions across five GBA editions pass; exact predecessor comparison reports 240 failures out of 450 assertions (ten callback-local checks cannot run there). Frozen current-main composition
5fe451e231passes 198 groups on fork main72c2a946; older-public composition4402bdd757passes 74 groups. Coverage includes absent/zero/invalid projection, provider errors, changed admission, graphics restoration, capture and complete native painting. Private consumer sources and native controller bodies remain unchanged. Real Metal Ruby3fec7460acwith unchanged consumerbddb5181: all 189 observed opening-particle draws share the fitted ball centre, maximum framebuffer error 0.00000763 pixels. The opponent tick-62 image shows the ring at the ball. Both send-outs, 11 throw captures, the command menu and cleanup pass without loader errors. There are zero premature-visible player rows in 553 pre-throw observations, zero hidden-actor violations in 82 observations, and zero duplicate cells in 378 opening passes. Other views/portraits, capture image acceptance and stable frame rates remain separate. Hosted CI is separate.Owned QA profiles/copies only, 20 GiB free-space floor; original ROMs and player saves/profiles unchanged.
Builds on #380 and the previously offered public component stack. Review the narrow production/fixture addition as
6ef0432d..3adaa863; older native bodies remain. Existing cartridge/art/stage/clock prerequisites are retained in qualification and still required for raw older main.Contributions by Roxas2712 — https://github.com/Roxas2712. Original additions are offered under LICENSE-ROXAS2712.md, including specific integration/distribution permission for Cedric / UNDERdecoded with visible credit. Existing upstream/third-party licences and rights remain intact.