Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player send-out observations always report rotation zero while the actual native ball advances. Existing presentation consumers use that unwrapped angle to advance from the trainer hand to the landing point and transition from grip size to flight size. They consequently remain stuck until opening, then jump to the target.
Project the actual native throw fraction through the existing angular observation. Do not add another clock or modify native positions, sounds, catch math, mon reveal, native painting or queue timing. Opponent/capture semantics stay as before, and imported durations still control progress.
Validation: 1,808 ball checks pass on all five GBA editions; the identical fixture reproduces 288 failures on predecessor
981b6f57. After integrating newer fork mainc548cd16, frozenb2c647a315passes 179 CPU groups including new Gen2 species and RS ice/continue regressions. Older-public compositiond54354c682passes 67 groups including the same ball checks. The actual unchanged private pure position/scale consumers pass 170 isolated checks: previously stuck through frame 24, now moving from frame 1 and transitioning to flight scale. Only unused factory declarations were stubbed; this is explicitly a pure-consumer math check.Rendered-flight acceptance remains pending: the real FireRed scene completes without loader errors, but the additional flight probe recorded no ball draws and is explicitly rejected as flight acceptance. Native send-out/render admission is still under investigation. No private consumer bodies or private file edits are included. Hosted CI is separate; only owned QA profiles/copies were used with the 20 GiB free floor, and player profiles were untouched.
Includes the preceding public components through #372; review the addon after
31dfa145. The composed qualification retains the previously offered native ball/stage/capture prerequisite byte-for-byte and applies only the scalar projection hunk. The new helper includes that prerequisite because it is absent from this older raw branch; no newer native simulation/controller is overlaid.Contributions by Roxas2712 — https://github.com/Roxas2712. Original additions are offered under LICENSE-ROXAS2712.md, including specific integration/distribution permission for Cedric / UNDERdecoded with visible credit. Existing upstream/third-party licences and rights remain intact.