Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A source battle renderer paints its fitted ball, then calls the opening-effect seam. That seam currently paints the full native ball again, producing two balls with different sizes and trajectories; this is visible in the real FireRed capture after send-out import was fixed.
Split the existing native painter into a whole-layer path and an opening-effects component. Ordinary native drawing retains its ball, particles and stars. A source opening pass borrows the same effects without adding another cell. A wrapper base call inside the genuine native whole-layer boundary still borrows that complete painter once. Neither path advances a clock or changes native queue/catch logic. No private renderer/controller body is copied.
Validation: 235 real-painter assertions across five editions and player/opponent/capture modes; the identical fixture reproduces 45 failures on exact predecessor
e8d494e1. Current fork composition passes 181 CPU groups after integrating freshly fetched main0af0b3cf, with four new-main appearance/new-game/ending groups passing separately. Older-public composition passes 69 groups including all 235 new assertions. Refreshed fork FireRed run368069098bnow passes both real starts, 69 actual ball frames and five captured flight frames: 412 source opening calls contain zero duplicate native cells; the complete native ball clock is identical to pre-splitb3d97aa123. Captures show one ball with grip-to-flight scale progression. Earlier49a837bef7had the same corrected images but was rejected by an overly broad all-target asset counter; that failed receipt is retained. The scoped observer preserves legitimate native painting. LeafGreen0237101bb2also passes both starts, 69 actual ball frames, five captures and 469 source opening passes with zero duplicate cells and no loader errors. An earlier relative-path QA startup failure is retained and its input-path handling corrected. The focused hosted fork ball workflow also passes ondd5a507d; this does not claim rendered acceptance of the older-public composition. No complete trainer-pose or FPS acceptance is claimed. Hosted CI is separate.Owned QA profiles/copies only, 20 GiB free-space floor; private files and player saves/profiles untouched.
Builds on the offered public component stack (#376 import, #374 progress). This branch also reuses the existing ball painter boundary offered in #329; its preimage is unchanged, and no newer native simulation body is overlaid. Review the component split as
cc2496d0..515e5b46. The qualified composition retains separately offered cartridge/art/stage prerequisites, which raw older main still needs for full integration.Contributions by Roxas2712 — https://github.com/Roxas2712. Original additions are offered under LICENSE-ROXAS2712.md, including specific integration/distribution permission for Cedric / UNDERdecoded with visible credit. Existing upstream/third-party licences and rights remain intact.