Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native GBA Encore currently stores a fixed three-phase timer without its original move slot. A previously selected alternative can still run, and the forced FIGHT path returns a nested descriptor that the native move dispatcher does not recognize.
Implement native Encore validation, its
0..3 + 3duration draw, original-slot binding, real residual expiry and PP/slot-edit cancellation. Plan using the forced move's priority while preserving the selected target; an Encore applied later also overrides the queued move and recomputes its target with native bounded RNG/redirection. Spend the actual learned slot's PP, preserve called moves and authored handlers, and retain bindings if Encore is cleared after planning. Known authored moves do not need cartridge indices.Keep
battle.turn_startedon the original declared action andbattle.move_usedon the actual executed move. Include Encore move/slot/duration in link state components, and use native command revision 4 to refuse older battle rules before party exchange. Native party revision and older-generation policies/goldens remain unchanged. The raw fixture changes fromc2a03195bc4588f9to8be423c61a4477a2, independently audited with the unchanged #218 hasher and only the explicit revision token.Stacks on #218. Gen1 remains an unchanged read-only reference; no Gen1 changes or publication.
Validation at clean feature runtime
6998a429a99dcc94d3f7c8b9a337ddfbcdaea3ba(later commit documents acceptance):535a5ec088c1ae1bf4d91dd3e35a56f64cf46d91. The new mode retains 612 complete observations per profile: all four slots and duration draws, failure guards, custom moves, actual residual expiry/slot edits, called PP semantics, late retargeting, public choices and cancellation after planning. Every bounded RNG call/value, all battler HP/PP and public move event/target are retained.ae385bae803e8a94eb4b2c73e2c1425d1a68868dpasses 234/234 engine suites, SDK 3/3, B30, the same 92/61,356 comparison and imported smoke. Integration preserves the existing native AI-order preparation and preselected double-battle enemy actions.Comparison boundary: the public-choice/planning cases receive the same explicitly prepared Quick Claw word. The combined fork's C-validated native order controller prepares it earlier than Gen1's standalone command; the original failed report retains that extra
0..65535call. No compared calls are filtered. These command-entry observations do not certify complete selection/RNG orchestration, global RNG/VBlank scheduling, GPU/pixel equality, a full playthrough or every other native producer/interaction.See
docs/native-gen3-encore.mdfor reproducible commands, schema mappings and limits. Hosted CI is tracked separately from local acceptance.The documented combined snapshot is pushed as
bbba8c25a6c61ea104a8ce1a2d8c4ece370e842ctoRoxas2712/Gen2Recomped:codex/portability-testing. Changes after the tested combined runtime only record validation. Forkmainremains13af468b.All eight hosted workflows currently require maintainer approval (
action_required). The dedicated contract run has zero jobs; local acceptance does not claim hosted execution. The app's 100-artifact cap prevented another attachment, but the regular PR remains published and linked.