Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native GBA Disable currently chooses a random usable slot, draws 1–8 phases and ages on action attempts. A faster Disable also leaves the already selected attack executable, so public eligibility and actual PP/action behavior can disagree.
Bind Disable to the target's last executed learned move, draw native
0..3 + 2duration and expire in the actual residual phase before Encore. Follow move identity through reordering and duplicates, retain the restriction at zero PP, and clear removed moves, switches and Transform correctly. Haze preserves native Disable. Interrupt a disabled queued move before PP, confusion and move-used events; clear last-move/multi-turn state, including Bide continuation. Called moves retain their native bypass.Use the same live identity in move admission,
mod.battle:snapshot(), stale-command tracking, UI hints and native AI predicates. Install builtin adapters per dataset before mods capture public handlers, preserving authored overrides/delegation and shared legacy statics. Other generations and legacy authored slot states retain their existing policy.Include native move/timer in active link state; advertise command revision 5, party codec 1. Independently audit raw fixture
8be423c61a4477a2→da62fe7b50f40107using the unchanged #219 hasher with only the revision token changed. Older-generation goldens are unchanged.Stacks on #219. Gen1 is an unchanged read-only reference; no Gen1 development or publication.
Validation at clean feature runtime
55f4301ab6ef190051b1f6d420f22636a61a1809(later commits document acceptance):535a5ec088c1ae1bf4d91dd3e35a56f64cf46d91. The new Disable mode adds 810 observations per FireRed/Emerald profile, retaining every bounded RNG call/value, all battler HP/PP/learned moves/last moves, actual events and native state. Covers all four slots and duration words, failure guards, custom/duplicate/reordered/removed moves, PP depletion, called/queued/confused execution, Bide/multi-turn interruption, Haze/Transform and residual expiry.Commands.selectionErrorwith hostBattleCommands.reason; it does not invent values for Gen1's omitted GBA snapshotdisabledfield.abd621282715d072b421e7b30f3f5c60628d771d: 237/237 engine suites, SDK 3/3, B30, the same 96/62,976 comparison and four imported smoke scenarios. Existing native AI-order and item/residual scheduling are preserved.See
docs/native-gen3-disable.mdfor commands, schema mappings and boundaries. This does not certify broader canceller/locked-move controllers, all Haze/Transform rules, whole-game RNG/VBlank, animations, UI pixels or a full playthrough. Existing prepared-input boundaries remain documented; no RNG calls or differing observations are filtered.The feature branch is pushed to
Roxas2712/Gen2Recomped:codex/gen3-disable. The combined fork publication and hosted CI status are tracked separately from local acceptance.Published combined snapshot:
Roxas2712/Gen2Recomped:codex/portability-testingat962fca8d879aba0520186acbbb4cb8e95f78cc5d. Changes after the tested combined runtime only add validation/publication documentation. Forkmainremains13af468b97dc37015d14ad5c71d7f067c3ee810d.All eight hosted workflows currently require maintainer approval (
action_required). The dedicated contract run has zero jobs, verified separately; local acceptance does not claim hosted execution. The app's 100-artifact identity cap rejected attachment, but the regular PR remains published and linked.