Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mod-selected GBA action such as
{move="TACKLE", target=2}currently loses its target during Gen2 execution. Resolve positional targets at execution time, after any occupant replacement, and honor them through native move/damage events and the actual double-turn queue.The move's native target policy remains authoritative. Both-foe/all-other ordering, self targeting and active Lightning Rod redirection follow the reference for the covered local GBA cases. Pressure counts every relevant holder, excludes the user's own self-targeted Pressure and spends PP once. Spread moves emit battle.move_used once per action; per-target hits remain battle.damage_dealt events. The zero-power GBA default path no longer emits a spurious zero-damage hit.
Stacked on #194. Review feature commit f84dfb56 relative to that prerequisite (11 files).
Validation:
Scope: selected mod-action targets in local GBA battles. Follow Me/unported effect producers, automatic AI target scoring, complete random/native RNG parity, called moves, link ordering, damage amounts and item/switch/watch actions remain separate work. Gen1 is a read-only reference; no Gen1 patch or publication is required. Hosted CI is reported separately from local acceptance.
Combined-fork validation: integrated into
Roxas2712:codex/portability-testing, production runtime 916661d. All 211/211 engine suites, 3/3 SDK suites and B30 pass. The same 20-worker / 312-observation comparison passes here too. Integration forwards the optional spread-continuation flag through the existing GBA held-item scheduler wrapper.Hosted CI: all three workflows report
action_requiredpending maintainer approval. The dedicated contract workflow has zero executed jobs. These are separate from local acceptance.