Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API-3 mods inspecting
next()insidebattle.enemy_actioncurrently receive Gen2's id-only move handle instead of Gen1's native move fields. Conditions such asaction.kind == "move"and edits ofaction.movetherefore require engine-specific branches.Expose the shared GBA native move fields for API 3: kind, native move ID, selected slot, user, positional battler and double-battle targetType. Retain the reference's symbolic STRUGGLE fallback. These are call-local views; unchanged native handles and learned move data retain their identity/state.
Authored numeric/name references remain intact between public hooks. Native hook links retain their physical Gen2 representations; a later native rewrite invalidates the older public reference snapshot. Existing canonical id edits, API-1/2 views, detached native actor queries and selected-slot PP semantics remain supported.
Stacked on #191. Review feature commit 3f01f29e relative to that prerequisite (12 files).
Validation:
Scope: native move records for API-3 GBA. No AI scores or target-selection result are fabricated. Item/switch/watch records, chosen double targets, other native fields, damage amounts, RNG traces and complete gameplay parity remain separate. No Gen1 source change or publication is required. Hosted CI is reported separately from local acceptance.
Combined-fork validation: integrated into
Roxas2712:codex/portability-testing, production runtime 679b549. All 210/210 engine suites, 3/3 SDK suites and B30 pass. The same 16-worker / 220-observation reference comparison passes on this runtime. Integration preserves the existing identity-roll boundary.Hosted CI: all three workflows report
action_requiredpending maintainer approval. The dedicated contract workflow has zero executed jobs. These are separate from local acceptance.