Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gen1Recomp exposes label-keyed engine prose separately from VM script text. Gen2Recomped lacks that registry, so portable translations either miss native readers or overwrite a script with the same label.
Add
mod.content.rom_textfor Gen 2 and the registered GBA games, with the shared API-3 source-string contract, rollback, freeze and guarded retirement. Gen-2 imported prose labels project into existing native label readers; battle prose uses the common formatter with named/positional slots and ending metadata. Same-spelling API-3 script records remain separate and are consumed by real native text commands, including empty/removed records and authored-prefix collisions. VM bank/address routing stays intact.Bind all five GBA Pokemon-storage actions and descriptions explicitly through the native storage-menu constructor. These are detached views: imported constants and GBA script text remain unchanged, and older-cache fallback screens receive the same overrides. Label membership/provenance is generated from pinned public import metadata, with no cartridge prose or copied importer implementation.
Coverage boundary: this adds the shared registry and its first verified native consumers. Other GBA party/item-PC/field-menu/battle-message readers still need explicit bindings. Gen-2 screens that print hardcoded fallbacks rather than reading labels also need reader changes. Registry availability is not a claim of universal cartridge-text, printer or glyph parity. GB/DS honestly report the registry unavailable. Native host API-1/2 uses strings; the reference's native GBA IR is not claimed as a shared native-API-2 format.
Validation
Feature runtime
52541d1b0160de2361a2bffe15fd4fad4eb9a20c; combined runtime62f8902617255195b4a12b176f171925c49209ec. Later feature changes are documentation only.535a5ec088c1ae1bf4d91dd3e35a56f64cf46d91.Stack
Depends on #170 and the earlier portability series. Incremental comparison against #170. The main-based diff includes unmerged prerequisites; the combined testfork also carries the independent baseline repairs.
All 31 hosted PR workflows report
action_requiredpending maintainer approval. The new ROM-prose workflow has zero executed jobs. The passing validation above is local.