Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native GBA menus still displayed imported or hardcoded labels after an API-3 mod overrode the corresponding
rom_textentries. Bind the FireRed/Emerald party action readers and their separate cancel buttons, plus FireRed's Item-PC withdrawal title, cancel row and submenu. The same public consumer runs through both engines without renderer replacements.FireRed uses the reference's
sCursorOptions[n]keys; Emerald uses its named labels through the real manifest branch. Keep primary TAKE/action CANCEL/footer labels distinct, preserve native fallbacks and action identities, and read the Item-PC title live so retiring a mod restores an already-open menu. Custom/TOSS titles retain their own text.Depends on #171. Incremental change: parent #171 → this branch.
Validation:
535a5ec; reference API 3 vs host API 3 and API 2/unified. Deterministic public label/table provenance; no cartridge text included.7a12243293dcb7a6ff2a00dc64490f3c6bb5aa32, including test: repair Gen2 updater asset fixtures #128–134 repairs: 192/192, SDK 3/3 and B30 pass.Further party prompts/mail/trade/field-move names, Item-PC quantity/results, Emerald's distinct Item-PC screen and battle prose remain separate work. Native smoke does not claim normal SAVE, full playthrough, fresh full-ROM import or pixel equality. Hosted CI is separate from local validation.
See
docs/portable-gba-menu-prose.mdandtools/gba-menu-prose-contract-check/README.md.Hosted CI at publication: all 32 PR workflows report
action_requiredpending maintainer approval. The GBA menu-prose workflow has zero executed jobs; these are not hosted-green results.