Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom battle UIs currently need to replace native move-menu input code to choose grid navigation. This adds the public
battle.move_grid_navigationpredicate at the real move-selection controller, preserving the original opaque battle/screen handle across API 1/2 and API 3.Only literal
trueselects the grid. The normal mode remains the default; Gen1 wide GB retains its fixed-grid bypass, and Gold-family wide mode accepts an explicit list override. The shared decision also controls Mimic selection. GBA doubles now clamp at row/column edges, correcting Gen2's previous generic wrapping to match Gen1's native doubles controller; DS retains its native grid behavior.Stack
Depends on #152 and the earlier portability series. Feature-only comparison: 97eac55…3800b63. Earlier changes appear in the main-based diff until their prerequisites merge.
Validation
79ea62f45fb2ea8f65d081a109431e4eb1bbdb36.c24e3a2f9987e1f420ed81a79c7f1e7caf61df72: 160/160 engine suites, SDK 3/3, B30 pass.Hosted CI: all 14 PR workflows currently report
action_requiredand await maintainer approval. The new battle-grid run has zero executed jobs. The passing results above are local validation.