Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom party UIs currently need to patch private input controllers to select grid navigation. This adds
ui.party.grid_navigationat the native GB/Gold-family and GBA battle-party controllers, with the original opaque menu handle in API 1/2 and API 3.Only literal
trueopts in. GB uses the shared row-major two-column policy with column wrapping and missing-cell handling; GBA chooses spatial neighbors from imported icon positions, with rendered-panel fallback for older caches and native Cancel behavior. Field menus, submenus, healing, scripted no-input screens and swap/HP-transfer selection keep their existing input ownership. Native confirm/cancel handlers remain in control, including GBA combined direction+A/B input.This changes navigation only. It does not add GBA double-layout artwork, replace menu art, or bypass battle switching rules. DS party screens retain their existing controller and report this hook unsupported until their native seam is implemented.
Stack
Depends on #153 and the earlier portability series. Feature-only comparison. Earlier changes appear in the main-based diff until their prerequisites merge.
Validation
79ea62f45fb2ea8f65d081a109431e4eb1bbdb36.1d1f202b28dabdc8d89361be7103e35c1d214de1: 161/161 engine suites, SDK 3/3, B30 pass.Hosted CI: all 15 PR workflows currently report
action_requiredand await maintainer approval. The new party-grid run has zero executed jobs. Results above are local validation.