Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mods that suppress native level text currently need different screen patches in Gen2Recomped. This adds Gen1Recomp's
pokemon.level_visiblecontract to the shared GB/GBA surfaces: returning literalfalsehides the complete level label and digits in battle, party and summary screens. Native status/egg eligibility, HP/EXP, input and progression stay intact; GB summary next-level numbers and their TO label/arrow are gated together.The hook receives
(mon, {where, game}), withwhereidentifyingbattle.enemy,battle.player,party, orsummary. It uses the existing Pokémon/context adapters for unified API 2 and API 3, checks subscriptions before allocating a context, and advertises only the implemented Gen1–3 call sites. DS renderers remain unavailable throughsupports. Includes an unchanged portable example, documentation and pinned cross-engine CI.Validation
callback_formatextension; API 3 is the common unified contract. All four modes pass on the feature branch and combined integration tree (80 worker runs / 680 paired observations).79ea62f45fb2ea8f65d081a109431e4eb1bbdb36: existing native Gen2 hook suite 645/645, native Gen3 hook suite 2,004/2,004, unchanged.b8efa1a8a21a00216c4be75a4c36b0f06b01bfd1).Stack
Depends on #150 and its prerequisite portability PRs. Feature-only change: ca7aed5…6e61c01. The combined QA tree also preserves the independent render/output and baseline-fix branches; their shared callback catalog entries were retained when combining the series.
Hosted CI
GitHub reports all 12 workflows as
action_requiredpending maintainer approval for this fork PR. The new level visibility contract run has no jobs yet. The passing results above are local checks against the published feature commit and combined QA tree; hosted CI has not executed.