Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gen1Recomp mods can prepare a trainer battle through
trainer.before_battle, but Gen2Recomped currently constructs the battle directly. Add native admission before ordinary trainer challenge completion and scripted trainer construction, with a retained one-shot continuation, cancellation and ordered battle-local player-party selection.Return literal
trueto defer; callcontinueBattle()to start,continueBattle({cancel=true})to cancel, or passplayerPartyIndices={3,2}to select that ordered subset. Save-party identity/order and the original Game are preserved. The selected view drives leads/doubles, switches, native party menus, EXP, party-based moves/AI and exhaustion.Native ownership and cancellation
Validation
trainer_before_battle15/15,unified_gen2_hooks645/645,unified_gen3_hooks2,004/2,004.git diff --checkpass. Validation is ROM-free; imported-ROM playthroughs and GPU pixel equivalence are not claimed.CI pins clean Gen1 commit
79ea62f45fb2ea8f65d081a109431e4eb1bbdb36, runs the untouched reference suites and uploads cross-engine reports. Classic workers use the native prepare helper and real constructors; Gen1 Gold uses its own scripted battle engine, and Gen1 GBA uses its actual BattleBridge.Stack
Depends on #149 and its prerequisites. This PR targets main to follow the existing series. Review the feature-only comparison against #149; please merge in stack order.
Hosted CI
All eleven fork workflows currently require maintainer approval (
action_required), including the new trainer preparation contract run. Its job list contains 0 jobs; hosted tests have not run yet. The passing results above are local, reproducible ROM-free runs.