Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gen2Recomped accepted API-3
battle.bottom_ui_visibleregistrations without a native producer. Alternate battle UIs therefore had to patch private draw methods to suppress native text/menu backings, including overlays pushed above the battle.Add the shared
(next, state)predicate to native BattleState text-area dispatch, WideBattle, TextBox and ChoiceBox. Only literal false hides drawing. Text/choice overlays inherit their nearest enclosing battle's decision; field YES/NO prompts do not become hook states. Hiding a move menu also removes its menu-row sprite clip. Native input/update ownership remains unchanged.The existing Gen2 claim API, claimant introspection, reset and failing-claim removal are preserved. Legacy denials take precedence over public-hook approval. The inheritance helper recognizes both native
isBattleStateand Gen1-styleisBattlemetadata without modifying classes. Capability/unified catalogs advertise the real producer.Stack / review scope
Depends on #146 and its existing prerequisites. This branch adds one feature commit above
af4571fa9037273879229c42c9f0219f016ddffa; the main-target diff also includes the unmerged prerequisites. Review only this change.Validation
79ea62f45fb2ea8f65d081a109431e4eb1bbdb36.The feature retains the parent's same ten failing suites and 17 failing assertions, with identical failure output. Separately proposed baseline fixes are included in the green combined integration at
a0e6c02f9869b6b8ca795ce97e108a97a9a398ff. Integration needed only documentation placement resolution.Boundaries
This controls bottom UI, not status-HUD visibility or whole-state visibility. Gen1 API 2 ignores the unified opt-in; that comparison uses native Gen1 API 2 against unified Gen2 API 2. API 3 preserves opaque state identity for this hook on both engines. The shared GBA draw observation uses the reference's native caught-Pokemon scene; its separate, unchanged native suite covers regular menus and confirmations. Existing renderer-specific error handling and presentation-counter timing remain unchanged.
Contract and reproduction commands describe native routing and fixture boundaries. Validation is ROM-free/headless; it does not claim GPU pixel equivalence, physical mirrored-display output or cartridge playthroughs.
Hosted CI
GitHub reports
action_requiredfor all 8 pull-request workflows; maintainer approval is required before the fork workflows can run. The new contract workflow has no started jobs. These are not hosted passes. Battle bottom UI contract run. Local feature and integration results above were completed on the published/tested commits.