Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mods using
battle.status_hud_visiblecan currently hide DS healthboxes in Gen2Recomped, but the same callback leaves the native GB/GBA status panels visible. Add the missing classic/wide GB/GBC and GBA single/double producers, using the existing false-only predicate and original opaque battle owner.A shared helper preserves existing DS custom-method veto/error fallback, accepts partial standalone battle objects and avoids dispatching the hook twice through the new native method. Hidden DS boxes still count as handled. Status visibility remains independent of battlers, battlefield/effects, party rows/summaries, bottom menus, input and logic. Capability queries now report the producer on all supported hosts.
Shared contract and scope
79ea62f45fb2ea8f65d081a109431e4eb1bbdb36. Documentation includes the full reproduction commands and callback-format boundaries.Validation
git diff --checkpass. All runs are ROM-free; imported-ROM playthroughs and pixel goldens are outside this validation.Stack
Depends on #147 and its prerequisites. This PR targets main to follow the existing series; the feature-only review is parent #147 to this branch. Please merge in stack order.
Hosted CI
GitHub currently requires maintainer approval for all nine fork workflows (
action_required), including the new status HUD contract run. Its job list is empty (0 jobs); no hosted tests have run yet. The passing results above are local, reproducible ROM-free runs.