Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portable scripts can now use play_sound, wait_sound, play_music, stop_music, fade_music, play_once and play_default_music on generations 1–3. Every cue is checked before admission and again at dispatch; native sources and music controllers handle playback, while bounded foreground waits prevent stalled audio from hanging a mod.
Depends on #117 (and its prerequisites). Merge that first. Implementation-only review: https://github.com/Roxas2712/Gen2Recomped/compare/1a09b6c7847a723805fd39e88ea0be17f5dc7795...1fa9d59d90fbb6391a4a6cf994de56c016f40436
Adds native Gen3 sequence-name/index resolution with ambiguity checks and native effect/file dispatch. Options are copied and validated. Retired scripts cannot resume or arm keepMusicOnce after a reentrant unload. Audio already committed to the native controller remains engine-owned.
Validation:
Gen1's Gen3 resolver accepts an unknown string as truthy during preflight; this implementation requires an actual native definition instead. Fade control follows the host controller, not a claim of identical waveform timing. Deferred dialogue cues are a separate follow-up.
Hosted Actions await maintainer approval for this fork (
action_required); no hosted pass is claimed: API 3 contracts, ci.