Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds play_cry, text_sound and engage_music to API-3 portable scripts on generations 1–3. Cues are validated before admission, armed for the next show_text/ask, and played after typing through the native dialogue/audio controllers. Questions wait for audio before presenting their native choice; cries preserve auto-close versus explicit button-wait behavior.
Depends on #118 and its prerequisites. Merge that first. Focused review: https://github.com/Roxas2712/Gen2Recomped/compare/1fa9d59d90fbb6391a4a6cf994de56c016f40436...8a6eca8ebcc5501bc390f39de6aeba75b2878d48
Retained callbacks are once-only and inert beneath unrelated UI or after retirement. A reentrant unload during playback or source polling aborts the native update before it can pop a foreign overlay. Assets are revalidated at arm, construction and playback. Native 600-frame gates prevent stalled sources from trapping dialogue.
Validation:
Combined cry+text_sound plays both on the host. The reference Gen1 options merge drops the text sound in that combination; shared comparisons cover the individual cues instead of reproducing that defect.
Hosted workflows await maintainer approval for this fork (
action_required): API 3, ci. No hosted pass is claimed.